A more modest error fallback #1533
Conversation
camielvs
force-pushed
the
12-11-a_more_modest_error_fallback
branch
2 times, most recently
from
fd5b1d4 to
ca40873
Compare
|
I'm not convinced that this should be the default behavior. I don't think there is a "one size fits all" solution. Instead I would advocate for per use-case solution. This specific case will be addressed in PR https://app.graphite.com/github/pr/TangleML/tangle-ui/1568/feat-optional-yaml-libraries (or can be done separately) |
|
There definitely isn't a one-size-fits-all solution. But I do feel something less intrusive and a little cleaner as the generic default would be nicer than what we have currently. |
camielvs
force-pushed
the
12-11-a_more_modest_error_fallback
branch
from
ca40873 to
89237d7
Compare
|
@maxy-shpfy I had a look at various scenarios where this new default could pop up. THere's quite a lot of places we're using the suspense wrapper already so it would be a bit much work to try manually define them all at this time. For now the default will need to suffice. See the random selection of screenshots below. Pipeline Row Component Editor Published Component Details Connected Library Code Viewer |
|
Seems okay. Definitely some cases where it could be improved but I think this is a step in the right direction. As discussed I'll merge in and we can iterate over time. |
Description
Changes the default error fallback for
useSuspenseWrapperto be a smaller, more modest icon rather than a large info box.Related Issue and Pull requests
Type of Change
Checklist
Screenshots (if applicable)
Before:
After:
Test Instructions
Additional Comments